Honour operator precedence in SQLite REGEXP, MATCH and GLOB - #2419
Merged
iffyio merged 1 commit intoAug 4, 2026
Merged
Conversation
LucaCappelletti94
marked this pull request as ready for review
July 31, 2026 14:39
iffyio
approved these changes
Aug 4, 2026
iffyio
left a comment
iffyio
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @LucaCappelletti94!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLiteDialect::parse_infixparsed the right operand ofREGEXP,MATCH, andGLOBwithparse_expr, and previously lead to mutating the meaning of boolean operations constructed with it.For instance,
a REGEXP 'p' AND b = 1parsed as aREGEXP ('p' AND b = 1)instead of(a REGEXP 'p') AND (b = 1).The hook was ignoring the precedence its caller passed, so using it fixes all three. Nothing errored before, and Display adds no parentheses, so the wrong tree reprinted as the original text. That is why a text round trip never caught it and the new test asserts on the tree instead.